Re: readline patch for 1.4.0

[Marius Vollmer]

Albert Chin-A-Young <address@hidden> writes:

> Addes --with-readline=DIR option to specify readline include/library
> in an alternate directory.

I don't think we should add this option.  In my opinion, the system
should be set up in such a way that readline and all other needed
libraries are automatically found.  This is much easier in the long
run.

There are some other changes in your patch that are more intersting,
tho.

>  dnl Should we check for curses, terminfo, and termlib, too?
> -for termlib in ncurses termcap ; do
> -   AC_CHECK_LIB(${termlib}, tgoto, 
> -                [LIBS="-l${termlib} $LIBS"; break])
> +for termlib in ncurses curses termcap terminfo termlib; do
> +   AC_CHECK_LIB(${termlib}, tputs, [LIBS="$LIBS -l${termlib}"; break])
>  done

You add "curses", "terminfo", and "termlib" here.  What is the
motivation for this?  I.e., on what systems do you need this?

> -if test $ac_cv_lib_readline_main = yes \
> -        -a $ac_cv_var_rl_getc_function = no; then
> +if test "$ac_cv_lib_readline_readline" = yes \
> +        -a "$ac_cv_var_rl_getc_function" = no; then

What are the quotes needed for?

Thanks!