branch master updated: goggles: Do not make %goggles-irc-log-directory world-writable.

[Ricardo Wurmus]

This is an automated email from the git hooks/post-receive script.

rekado pushed a commit to branch master
in repository maintenance.

The following commit(s) were added to refs/heads/master by this push:
     new 9c49b7c  goggles: Do not make %goggles-irc-log-directory 
world-writable.
9c49b7c is described below

commit 9c49b7c10f2129eabd97ab7bf8dcf7ab493c24cf
Author: Ricardo Wurmus <rekado@elephly.net>
AuthorDate: Wed Nov 9 12:37:24 2022 +0100

    goggles: Do not make %goggles-irc-log-directory world-writable.
    
    * hydra/modules/sysadmin/services.scm (%goggles-activation): Do not
    create the IRC log directory, and don't make it world-writable; the
    directory is created by goggles-bot-activation.
---
 hydra/modules/sysadmin/services.scm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/hydra/modules/sysadmin/services.scm 
b/hydra/modules/sysadmin/services.scm
index a00ba0c..11404d4 100644
--- a/hydra/modules/sysadmin/services.scm
+++ b/hydra/modules/sysadmin/services.scm
@@ -1,7 +1,7 @@
 ;;; GNU Guix system administration tools.
 ;;;
 ;;; Copyright © 2016-2022 Ludovic Courtès <ludo@gnu.org>
-;;; Copyright © 2017, 2018, 2020 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2017, 2018, 2020, 2022 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This program is free software: you can redistribute it and/or modify
 ;;; it under the terms of the GNU General Public License as published by
@@ -666,7 +666,8 @@ to a selected directory.")
   "/var/cache/logs.xapian")
 
 (define %goggles-irc-log-directory
-  ;; Directory where IRC logs are stored (by a separate znc process).
+  ;; Directory where IRC logs are stored by goggles-bot.  The
+  ;; directory is created as part of goggles-bot-activation.
   "/var/www/.well-known/all-logs")
 
 (define %goggles-activation
@@ -676,12 +677,7 @@ to a selected directory.")
         (let ((user (getpwnam "goggles")))
           (mkdir-p #$%goggles-cache-directory)
           (chown #$%goggles-cache-directory
-                 (passwd:uid user) (passwd:gid user))
-
-          ;; FIXME: This is world-writable!  TODO: Write a service to start
-          ;; znc and run it as user "goggles".
-          (mkdir-p #$%goggles-irc-log-directory)
-          (chmod #$%goggles-irc-log-directory #o777)))))
+                 (passwd:uid user) (passwd:gid user))))))
 
 (define (goggles-shepherd-services goggles)
   (with-imported-modules (source-module-closure