Re: Icecat - WebGL support

[Julien Lepiller]

Le 11 juin 2020 16:26:19 GMT-04:00, Ekaitz Zarraga <ekaitz@elenq.tech> a écrit :
>‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>On Sunday, June 7, 2020 12:59 PM, Ekaitz Zarraga <ekaitz@elenq.tech>
>wrote:
>
>>
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On Saturday, June 6, 2020 9:27 PM, Julien Lepiller julien@lepiller.eu
>wrote:
>>
>> > Le 6 juin 2020 15:14:07 GMT-04:00, Ekaitz Zarraga ekaitz@elenq.tech
>a écrit :
>> >
>> > > Wait a minute! It's working!
>> > > But the only way to work is with the LD_LIBRARY_PATH set. I
>installed
>> > > mesa and set the LD_LIBRARY_PATH from my command line, an icecat
>run
>> > > from the command line works, the one run from the desktop
>environment
>> > > doesn't.
>> > > So... guix is not setting the LD_LIBRARY_PATH correctly for Mesa
>and
>> > > that's why IceCat is unable to find it?
>> >
>> > I see icecat is wrapped for pulseaudio to work, so we might as well
>wrap mesa.
>>
>> It already has Mesa as an input, too.
>> Looks like it's just a matter of the LD_LIBRARY_PATH not being set.
>>
>> Thoughts?
>
>Hi all,
>
>I made this change in the package and it seems to work.
>
>If it looks fine I'll send the patch.
>
>Thanks!
>
>diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>index 7bf9850e97..570398ecd9 100644
>--- a/gnu/packages/gnuzilla.scm
>+++ b/gnu/packages/gnuzilla.scm
>@@ -1112,11 +1112,13 @@ from forcing GEXP-PROMISE."
>                     (lib (string-append out "/lib"))
>                     (gtk (assoc-ref inputs "gtk+"))
>                     (gtk-share (string-append gtk "/share"))
>+                    (mesa (assoc-ref inputs "mesa"))
>+                    (mesa-lib (string-append mesa "/lib"))
>                     (pulseaudio (assoc-ref inputs "pulseaudio"))
>                    (pulseaudio-lib (string-append pulseaudio "/lib")))
>                (wrap-program (car (find-files lib "^icecat$"))
>                  `("XDG_DATA_DIRS" prefix (,gtk-share))
>-                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib)))
>+                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib
>,mesa-lib)))
>                #t))))))
>     (home-page "https://www.gnu.org/software/gnuzilla/";)
>     (synopsis "Entirely free browser derived from Mozilla Firefox")

Looks great! Please send the patch :)