Re: Protect CVSROOT tree

[Dale Miller]

Howard,

Everyone accesses our CVS repository using pserver, even if they are on the
cm processor where the repository is.

The repository is owned by cmbuild and there is a CM group.
The CM group is limited to certain people that match the list in my program.
That is also why I could test the group instead of hardcoding a list.

I have the CVSROOT/passwd file set up so that everone is running as cmbuild
which gives people access to the repository.  However, I do not want people
changing files in CVSROOT so I use my program.

ls -ld $cvsroot/CVSROOT
drwxrwxr-x   3 cmbuild  CM          8192 Dec 15 18:03 /sdhs_mnt2/cvsroot/CVSROOT

Dale



Howard Zhou wrote:

> Hi, Dale,
>
> I don't see how this solution prevent someone in the group going to $CVSROOT
> and do rm, chmod, mv ,etc? Please advise.
>
> Howard
>
> ----- Original Message -----
> From: "Dale Miller" <address@hidden>
> To: "Howard Zhou" <address@hidden>
> Cc: <address@hidden>
> Sent: Tuesday, December 19, 2000 6:17 AM
> Subject: Re: Protect CVSROOT tree
>
> > Howard Zhou wrote:
> >
> > > Hi, CVS users,
> > >
> > > CVSROOT directory tree is protect by a group permission. However this is
> not
> > > good enough since everybody in the group can go there and make change
> > > directly in the CVS repository.
> > >
> > > If you take off the group permission, then you have to figure out a way
> to
> > > make change via setuid program. However, cvs seems to ignore effective
> > > setuid.
> > >
> > > Therefore I'd like to know if there is any appropriate way to protect
> the
> > > CVSROOT repository from being modified besides the owner of the CVSROOT.
> > >
> > > Thanks in advance.
> > >
> > > Howard
> > >
> >
> > Howard,
> > I responded to this same question once before with the following:
> >
> > I restrict people from being able to commit to CVSROOT by using
> commitinfo.
> >
> > I added the following line to commitinfo:
> > CVSROOT $CVSROOT/CVSROOT/commitinfo_ckuser -user=$USER
> >
> > I added commitinfo_ckuser in checkoutlist so that it is available with the
> > other administrative files.
> >
> > And my commitinfo_ckuser program looks like the following:
> > ----------------------  < cut here > ----------------------------------
> > #!/usr/local/bin/perl -ws
> > # commitinfo_ckuser    D.Miller
> > #   called by commitinfo
> > #
> > #  $Id: commitinfo_ckuser,v 1.6 2000/09/20 16:06:46 miller Exp $
> > #
> > #  This program is called by $CVSROOT/CVSROOT/commitinfo
> > #  and is used to verify if user is authorized for changing CVSROOT
> > #  so that commit to CVSROOT files can be restricted
> > #
> > #  The logfile is not used at this time.
> > #
> >
> > $user    = $ENV{"USER"} unless defined $user;
> > $CVSROOT = $ENV{"CVSROOT"} unless defined $CVSROOT;
> > $logfile = "$CVSROOT/CVSROOT/commitinfo_ckuser.log" unless defined
> $logfile;
> >
> > print "\$CVSROOT=$CVSROOT\n";
> >
> > %authorized = ($user =>0,        #prevent uninitialized variable
> >                'miller' =>1,     #authorized users for CVSROOT checkin
> >                'heuston' =>1,
> >                'cmbuild' =>1,
> >                'cmvmgr' =>1,
> >                'brodzell' =>1
> >               );
> >
> >
> > ($repository, @files) = @ARGV;
> >
> > $ck_user = @ck_user = getpwnam $user;  # checking if user exists locally
> >
> > if ($repository =~ /$CVSROOT\/CVSROOT/) {
> >     if (($authorized{$user} == 0) || ($ck_user == 0)) {
> >         print "You are not authorized to commit CVSROOT files.\n";
> >         exit 1;    # <<<<----------------------<<<<<<<<<<<
> >     }
> > }
> >
> > exit 0;            # <<<<----------------------<<<<<<<<<<<
> >
> > # current date and time
> > $sec = $mday = $mday = $wday = $wday = $yday = $isdst = 0;  #not used
> > ($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst) =
> gmtime(time);
> > $date = sprintf("%4d%02d%02s-%02d:%02d", ($year + 1900), ($mon + 1),
> $mday,
> > $hour,
> > $min);
> >
> > open(LOGFILE, ">>$logfile") or die "Cannot append to $logfile: $!\n";
> >
> > print LOGFILE "$date $user $repository @files\n";
> >
> > close(LOGFILE);
> > ----------------------  < cut here > ----------------------------------
> > I currently have the log file code turned off.
> > This version has a hard coded list of authorized users, however, I have
> also
> > done
> > it by checking the users group.  This version also checks if a person has
> a
> > local
> > account
> > using:   $ck_user = @ck_user = getpwnam $user;  # checking if user exists
> > locally
> >
> > If none of your users have local accounts you could use that method and
> have no
> > hard coded authorized list.
> >
> > I find it simple and it works.
> > Dale Miller
> >
> >
> >
> >
> > _______________________________________________
> > Info-cvs mailing list
> > address@hidden
> > http://mail.gnu.org/mailman/listinfo/info-cvs