info-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem with "co -d xx -n" : bug or feature?


From: Derek R. Price
Subject: Re: problem with "co -d xx -n" : bug or feature?
Date: Tue, 27 Feb 2001 12:09:30 -0500

Larry Jones wrote:

> Derek R. Price writes:
> >
> > Larry checked in a more correct fix for this on the 21st:
> >
> > 2001-02-21  Larry Jones  <address@hidden>
> >
> >         * modules.c, cvs.h (do_module): Add build_dirs argument and use it
> >         instead of run_module_prog.  Change all callers.
> >         * tag.c (cvstag): For rtag, don't build directories.
> >         * sanity.sh (modules3): Update to match.
> >
> > Chris Cameron wrote:
> >
> > > If anyone is still interested, I located the information in our CVS 
> > > source.
> > >  This diff is against 1.10, but it is only a couple of lines to change.  
> > > It
> > > is a patch to allow & and -d to be used in one line in the modules file
> > > (like Cederqvist says you can!).  We downloaded the original patch from 
> > > the
> > > CVS web page
>
> Unless I misread Chris's patch, they're unrelated -- my patch fixed a
> problem with rtag trying to create local directories, Chris's patch
> fixes a problem with -d being ignored in & module definitions.

I wasn't sure you fixed this completely as a side effect, so I didn't say so, 
but
I believe Chris's problem was a side effect of the run_module_prog nasty-hack.  
I
only read the code and haven't tested this yet, but when run_modules_prog was 
!set
the mkdir code was being jumped over.  You replaced that section correctly with
the build_dir/!pipeout stuff.

I'll try and write a sanity case.

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden     OpenAvenue ( http://OpenAvenue.com )
--
I find that the harder I work, the more luck I seem to have.

                        - Thomas Jefferson






reply via email to

[Prev in Thread] Current Thread [Next in Thread]