Re: After upgrading to 1.11.1, loginfo inserts filename in command

[Larry Jones]

address@hidden writes:
> 
> When I looked at the mail that was attempted to send it showed:
> ...
> To: address@hidden, loginfo, address@hidden
> ...
> 
> Our loginfo line is simply:
> ^CVSROOT                mail -s "CVSROOT Updated %s" address@hidden
> address@hidden
> 
> Where did the user "loginfo" come from?  Did the format for loginfo change in
> 1.11.1?  Are we missing a patch?

The way the string is expanded changed to avoid problems with filenames
that contain shell meta-characters.  Unfortunately, it breaks your
usage.  %s now expands to a double-quoted string, which makes your
command line expand to:

        mail -s "CVSROOT Updated "CVSROOT logmsg"" eric_muehrcke...

so the double-quotes in the expansion of %s interfere with the double
quotes in your command line.  You can either move the %s outside the
double quotes:

        ^CVSROOT mail -s "CVSROOT Updated "%s address@hidden address@hidden

or use single quotes instead:

        ^CVSROOT mail -s 'CVSROOT Updated %s' address@hidden address@hidden

(although you should note that that won't work right if %s has single
quotes in its expansion).

-Larry Jones

It's like SOMEthing... I just can't think of it. -- Calvin