Re: Locking while tagging problem

[Larry Jones]

Pyatt, Scott writes:
> 
> 1. Is this a new "feature" in CVS 1.11.1p1 or a bug?

It's an important bug fix, implemented sub-optimally.  The directory-at-
a-time locking was seriously flawed in that CVS actually read the RCS
files and cached some of their contents *before* locking the directory. 
That means that it was possible for a commit to happen between the time
that tag first read the file and the time it locked the directory; when
the file was rewritten to apply the tag, the commit would be lost. 

Because of the way CVS is architected, the only easy way to solve the
problem was to lock the whole directory tree up-front, like commit does.
Fixing the directory-at-a-time locking would be a better fix, but it
would also require a *lot* of effort.

-Larry Jones

Please tell me I'm adopted. -- Calvin