Re: Bug with loginfo and CVSROOT administrative file rebuilding ?

[Olivier Berger]

"Greg A. Woods" wrote:
> 
> [ On Thursday, August 23, 2001 at 11:18:08 (-0400), Larry Jones wrote: ]
> > Subject: Re: Bug with loginfo and CVSROOT administrative file rebuilding ?
> >
> > Olivier Berger writes:
> > >
> > > If CVSROOT/loginfo contains a rule which launches a script on commits in
> > > CVSROOT/, and if the script fails, then the files in CVSROOT won't get
> > > checkout-out again (rebuilding administrative files stage, after the
> > > commit).
> >
> > I can't reproduce this problem -- what version of CVS are you running?
> 
> Even if it were reproducible I wouldn't consider it a bug in CVS -- it's
> more a bug in your management process.
> 
> If the `loginfo' file were any other source file for some program you'd
> likely have compiled and tested the program before committing the
> change.

Of course one has to unit-test before releasing !

>  You must do the same to the CVS administrative files too (which
> might mean creating a test repository and committing your new
> administrative files to it first and then doing some common test
> operations in the test repo to ensure the changes to the administrative
> files work as expected).
> 

But, the problem is that even if loginfo fails, it should not prevent
the commit to be made.

I consider that a commit to CVSROOT is only complete when the
administrative files have been reconstructed.

So I cannot agree with you... even if I put something wrong in my
loginfo file, It must be committed (and then put in fonction) whatever
wrong is in loginfo.

The fact that it cannot pe reproduced in the latest version tends to
make me think I'm right on this one ;)

Regards,
-- 
Olivier BERGER                          IDEALX S.A.S.
Développeur senior                      15-17, av. de Ségur
01.44.42.00.00                          F-75007 PARIS
06.81.27.86.79                          http://IDEALX.com/