Re: A bunch of questions about commitinfo

[Marc Haber]

On Thu, Nov 08, 2001 at 01:18:14PM -0500, Greg A. Woods wrote:
> [ On Thursday, November 8, 2001 at 11:53:07 (+0100), Marc Haber wrote: ]
> > Subject: A bunch of questions about commitinfo
> >
> > I feel that commitinfo is the correct place to do this. However, I
> > would like to ask if somebody has already done this and might care to
> > share experiences.
> 
> It should work -- if the program called by commitinfo exits non-zero the
> commit operation is failed....
> 
> It might be a lot easier though to simply institute a checking process
> that people are drilled to run prior to doing any commits.  Eg.:
> 
>       make check

Drilling people doesn't work :-(

> Either way the biggest problem I see is with how you will detect any
> errors.  IIRC 'named' won't even begin to load the zone files until it's
> opened the socket it'll listen for queries on.  You can of course create
> a special config that listens on some unused high-numbered random port,
> and which writes the log messages related to zone file loading
> explicitly to a specified file, and you can start it so it runs only in
> the foreground.  I don't quite know how you get it to exit after it's
> done loading the files though.  Named doesn't have a '-t' flag like
> dhcpd does.

We already have that. The test named will listen on 127.0.0.3:53, and
it is terminated by our script after parsing output.

> > Am I allowed to make changes to the repository in my commitinfo
> > script?
> 
> Nope.  Why would you want to?  All you're supposed to be doing here is
> validating the source files and either approving them or rejecting them.

I see. That's bad.

What I am planning is generating a named.conf fragment in the
commitinfo script, so that in case of new zones being added to the
repository the corresponding zone entry in the named.conf file can be
generated automatically. Also, I'd like to automatically add
allow-query clauses to named.conf for every zone that is loaded
automatically.

> > Any hints will be appreciated. Thanks in advance.
> 
> If you're comfortable with using perl for this task then have a look at
> the contrib/commit_prep.pl script.  It validates the $Id in the source
> file.  You could simply extend it to also do a test of the file syntax.

I will take a look into that, thanks for your comments.

Greetings
Marc

-- 
-----------------------------------------------------------------------------
Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
Karlsruhe, Germany |  lose things."    Winona Ryder | Fon: *49 721 966 32 15
Nordisch by Nature |  How to make an American Quilt | Fax: *49 721 966 31 29