Re: Building CVS on Windows is broken...again

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dennis Jones wrote:

>The latest version of CVS (1.11.13) fails to build on Windows...again.


If you'd like to volunteer to set up nightly testing on Windows for the
CVS tree...

>Building from the command line using NMAKE, results in the following
errors:
>
>.\src\subr.c(939) : error C2065: 'F_GETFL' : undeclared identifier
>.\src\subr.c(942) : error C2065: 'F_SETFL' : undeclared identifier
>.\src\subr.c(942) : error C2065: 'O_NONBLOCK' : undeclared identifier
>
>Apparently, a new function called, set_nonblock_fd(), has been added to
this
>version of CVS, but was never tested for its buildability on Windows.  The
>new function calls fcntl(), which is not available to Windows NT.  I even
>found the following comment in the windows-NT/run.c file:
>
>/*
>   You can apparently specify _O_NOINHERIT when you open a file, but
there's
>   apparently no fcntl function, so you can't change that bit on an
existing
>   file descriptor.
>*/
>
>So somebody obviously knew that fcntl() wasn't available to Windows NT, but
>whoever wrote set_nonblock_fd() either didn't know it, or forgot.


Actually, set_nonblock_fd() used to be in server.c, which wasn't
compiled on Windows, and I simply moved it into subr.c, which is
compiled under Windows.  You are correct about my not knowing fcntl()
wouldn't be available under Windows, however.

Now, are you _sure_ there is no equivalent to fcntl() under Windows?  I
notice that both windows-nt/run.c and windows-nt/rcmd.c are including
<fcntl.h>.  Are you certain there isn't just some library we're
neglecting to include or some other function name (like "_fcntl()") we
should be using?  I've seen similar problems with other POSIX functions
under Windows.

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAL8J6LD1OTBfyMaQRAvGMAJ9/aMVBy6C7gekuVJ/dBZY5IRAIQwCgvsyp
VY34L5BNd5SApEhlrn9Tkik=
=2GaY
-----END PGP SIGNATURE-----