Re: Watch add failing

[Mark D. Baushke]

Carter Thompson <address@hidden> writes:

> I checked the archives and Googled for "cvs watch add server aborted"
> to find out if the problems I've been experiencing with cvs watches 
> was known:
> 
> cvs watch add filename
> cvs [server aborted]: unknown command: watch_add
> 
> I've found multiple reports that this is a known problem in older
> releases of CVS, however no one has stated in which release it's
> been fixed.  I tried querying the www.cvshome.org issue tracking
> system without luck, does anyone know what release this has been
> fixed in?  I'll likely upgrade to the latest stable version but 
> I think my superiors would like to know in which release this 
> was fixed (not entirely sure why).
> 
> Many thanks,
> 
> Carter.

There was a problem for a short time in consistency of the set of
'cvs watch' commands. The version where this got cleaned up to use
'watch' rather than 'watch_add' was version 1.11.3.

So, the following versions are all using the "watch_add" protocol
command:

        1.9.27, 1.9.28, 1.10, 1.10.2, 1.10.5, 1.10.6, 1.10.7, 1.10.8,
        1.11, 1.11.1p1, 1.11.2

which had the server.c 'serve_watch_add' function calling

    do_cvs_command ("watch_add", watch_add);

instead of using

    do_cvs_command ("watch", watch_add);

as is done in cvs versions starting with 1.11.3.
That is, the 'watch_add' is an unknown command for the following
versions of cvs: 

        1.11.3, 1.11.4, 1.11.5, 1.11.6, 1.11.7, 1.11.8, 1.11.9, 1.11.10,
        1.11.11, 1.11.13, 1.11.14, 1.12.1 1.12.2, 1.12.3, 1.12.4, 1.12.5

and will remain an unkown command going forward.

Note that some distributions appear to have provided a patch for older
versions of cvs to interoperate with newer versions. One such message
(about the Debian distribution) is included below.

        Enjoy!
        -- Mark

            --------------- archive message ---------------
Date: Tue, 14 Jan 2003 17:53:10 +1100
From: ADFH <address@hidden>
To: address@hidden
Message-Id: <address@hidden>
In-Reply-To: <address@hidden>
References: <address@hidden>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: CVS and multiple platforms - version conflicts, features
 available etc.

After several helpful comments from people here, and a bit of digging
around, have been examining 1.11.4 from cvshome.org as well as the
source package from Debian for 1.11.2...

Have noticed something .. in the Debian 1.11.2 source package, there is
a patch file which adjusts server.c's handling of watch statements..

Is the following a problem with the patch in the debian 1.11.2 package,
or a problem inherent with 1.11.2 - and would either necessitate an
upgrade to 1.11.4 (which isn't available as a package for debian yet)?

For example - server.c exerpt
-----------------------------
serve_watch_add (arg)
    char *arg;
{
    do_cvs_command ("watch_add", watch_add);
}

Patch file 10_watch_on_pserver exerpt
-------------------------------------
@@ -3732,7 +3732,7 @@
 serve_watch_add (arg)
     char *arg;
 {
-    do_cvs_command ("watch_add", watch_add);
+    do_cvs_command ("watch", watch_add);
 }

... would this have anything to do with the following?

Example session
---------------
$ cvs watch add -R -a all *
cvs watch: warning: directory CVS specified in argument
cvs watch: but CVS uses CVS for its own purposes; skipping CVS directory
cvs [server aborted]: unknown command: watch_add
cvs [watch aborted]: end of file from server (consult above messages if any)