Re: How to format source code on commit

[Todd Denniston]

"Mark D. Baushke" wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Frederic Brehm <address@hidden> writes:
> 
> > At 12:46 PM 11/9/2004, Matt Doar wrote:
> > >We use client/server. I believe that the local file is formatted and
> > >then sent to the server. Perhaps I'm mistaken?
> >
> > commitinfo, loginfo, and other CVSROOT scripts run on the server. If
> > they didn't then it would be impossible (or at least extremely
> > difficult) to write a *info script for a heterogeneous development
> > environment.
> 
> Correct.
> 
> If commitinfo modifies the server-side copy of the file, then you had
> better hope/pray/force that the file also has an RCS keyword in it to
> trigger the server_updated() code to send a copy of the committed file
> back to the client. Otherwise, the client-side copy of the file will be
> different in ways unanticipated by the user.
> 
>         -- Mark
for some reason I thought the mailing list had discussed this thoroughly in
the past but the only thing I am finding is the thread on "applying astyle on
commit"[1], which says the same thing as Mark. 

I believed the general thought on commitinfo (or *info) scripts was they were
to TEST if the operation should be allowed, if the test failed then the user
was to fix the problem reported.
Changing things as they are checked in means that what the repository says was
checked in is different than what the user intended to check in, even if that
difference is only white space formatting.  Yes I am that address@hidden&#% 
user who
will say, "no that is not what I checked in, we must have a security
violation, fry the CM person" :)

[1] http://lists.gnu.org/archive/html/info-cvs/2001-04/msg00529.html

-- 
Todd Denniston
Crane Division, Naval Surface Warfare Center (NSWC Crane) 
Harnessing the Power of Technology for the Warfighter