Re: [sheet prep 0/6] preparatory commits for sheet rewrite

[John Darrington]

All these changes look fine to me.
J'
On Wed, Jun 22, 2011 at 08:33:09PM -0700, Ben Pfaff wrote:
     I'm working on a new data sheet for the GUI.  Here are some cleanup
     commits that prepare for it.  I believe that they are beneficial on
     their own.
     
     I've also pushed these to a branch named "psppsheet" in the Savannah
     Git repository.
     
     Ben Pfaff (6):
       gui: Drop 'dict' parameter from text_to_value().
       gui: Consistently use print format instead of write format.
       gui: Simplify value_to_text() parameters.
       gui: Eliminate some dependencies on the dictionary.
       gui: Strip numerics and strings differently in value_to_text().
       gui: Move some formatting functions into PSPP core.
     
      src/data/format.c                 |   50 ++++++++++++++++++++++
      src/data/format.h                 |    1 +
      src/data/variable.c               |   40 ++++++++++++++++++
      src/data/variable.h               |    7 ++-
      src/ui/gui/find-dialog.c          |   29 +++++--------
      src/ui/gui/helper.c               |   27 ++++++++----
      src/ui/gui/helper.h               |    5 +--
      src/ui/gui/missing-val-dialog.c   |   22 ++++------
      src/ui/gui/missing-val-dialog.h   |    5 +--
      src/ui/gui/psppire-data-store.c   |    4 +-
      src/ui/gui/psppire-dictview.c     |    4 +-
      src/ui/gui/psppire-var-sheet.c    |   12 ++----
      src/ui/gui/psppire-var-store.c    |   83 
++++---------------------------------
      src/ui/gui/val-labs-dialog.c      |   16 +------
      src/ui/gui/val-labs-dialog.h      |    4 +-
      src/ui/gui/var-display.c          |   19 ++-------
      src/ui/gui/var-display.h          |    1 -
      src/ui/gui/var-type-dialog.c      |   43 ++++++++-----------
      src/ui/gui/var-type-dialog.h      |    8 +---
      src/ui/gui/variable-info-dialog.c |    5 +-
      20 files changed, 184 insertions(+), 201 deletions(-)
     
     -- 
     1.7.2.5
     
     
     _______________________________________________
     pspp-dev mailing list
     address@hidden
     https://lists.gnu.org/mailman/listinfo/pspp-dev

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature