Re: pspp-devel 0.7.8 g4da697

[John Darrington]

Yes..

In commit 228b83840e3f053aecfa9feac395fb6855adf044 I added several lines of the 
form:

tests_language_lexer_scan_test_LDADD =  src/libpspp/libpspp.la  gl/libgl.la 

in order to avoid link errors about undefined symbols.

Right now, I see that tests/automake.mk contains the code:

check_PROGRAMS += tests/language/lexer/scan-test
tests_language_lexer_scan_test_SOURCES = \
        src/data/identifier.c \
        src/language/lexer/command-name.c \
        src/language/lexer/scan.c \
        src/language/lexer/segment.c \
        src/language/lexer/token.c \
        src/libpspp/pool.c \
        src/libpspp/prompt.c \
        src/libpspp/str.c \
        src/libpspp/temp-file.c \
        tests/language/lexer/scan-test.c

tests_language_lexer_scan_test_CFLAGS = $(AM_CFLAGS)
tests_language_lexer_scan_test_LDADD = \
        src/libpspp/libpspp.la \
        gl/libgl.la 


So it's obviously getting close_temp_file once from src/libpspp/temp-file.c and
once from src/libpspp/libpspp.la
I guess that deleting the lines matching src/libpspp/*.c should fix Jeremy's 
problem.

J'


On Sun, Jul 03, 2011 at 09:45:19AM -0700, Ben Pfaff wrote:
     John, does the following failure ring any bells for you?  I know
     that you were looking at issues related to temporary files.
     
     Jeremy Lavergne <address@hidden> writes:
     
     > I had a failure while doing the tests:
     >
     > ld: duplicate symbol _close_temp_file in 
src/libpspp/.libs/libpspp.a(src_libpspp_libpspp_la-temp-file.o) and 
src/libpspp/tests_language_lexer_scan_test-temp-file.o for architecture x86_64
     > collect2: ld returned 1 exit status
     > make[3]: *** [tests/language/lexer/scan-test] Error 1
     -- 
     Ben Pfaff 
     http://benpfaff.org

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.

signature.asc
Description: Digital signature