[Qemu-commits] [qemu/qemu] b4850e: hw/arm/boot: always clear r0 when booting kernels

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b4850e5ae9607f9f31932f693ca48f52619493d7
      
https://github.com/qemu/qemu/commit/b4850e5ae9607f9f31932f693ca48f52619493d7
  Author: Sylvain Garrigues <address@hidden>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M hw/arm/boot.c

  Log Message:
  -----------
  hw/arm/boot: always clear r0 when booting kernels

The 32-bit ARM Linux kernel booting ABI requires that r0 is 0
when calling the kernel image. A bug in commit 10b8ec73e610e01
meant that for boards which use the write_board_setup hook (which
means "highbank", "midway", "raspi2" and "xilinx-zynq-a9") we
were incorrectly skipping the "clear r0" instruction in the
mini-bootloader. Use the right offset in the "add lr, pc, #n"
instruction so that we return from the board-setup code to the
correct place.

Signed-off-by: Sylvain Garrigues <address@hidden>
[PMM: Expanded commit message]
Cc: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>