[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism. |
Date: |
Fri, 18 Jan 2013 16:19:02 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> Hmm, adler32() is basically a weak hashing mechanism; are you sure you
> won't have any false collisions? Furthermore, how does this compare
> with the series for adding deduplication, which uses much
> stronger/longer hashes, but where those take more time to compute? Is
> there any way you can share efforts between the two series?
I agree that using sha256 would be a better option as it will not be called
frequently.
However the call to gnutls is a one liner so it's likely not shareable.
The configure would need to be modified to require gnutls and It likely not
factorisable either.
I'll change the code to use sha256.
Regards
Benoît
>
> > + /* get the index of the first successfull read */
>
> s/successfull/successful/ (several times in this patch)
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
- [Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close()., (continued)
- [Qemu-devel] [RFC V6 03/11] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 04/11] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 06/11] quorum: Add quorum_aio_readv., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 09/11] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 10/11] quorum: Add quorum_co_is_allocated., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 08/11] quorum: Add quorum_getlength()., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 11/11] quorum: Add quorum_co_flush()., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2013/01/17
- [Qemu-devel] [RFC V6 01/11] quorum: Create quorum .c, add QuorumSingleAIOCB and QuorumAIOCB., Benoît Canet, 2013/01/17