[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__ |
Date: |
Tue, 31 Jan 2017 10:28:57 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 |
On 31/01/2017 10:26, Peter Maydell wrote:
> On 31 January 2017 at 15:16, Eric Blake <address@hidden> wrote:
>> The do-nothing fallback works for me; I'm just debating whether it is
>> dead code or whether we really would have a user building with a
>> compiler that old.
>
> OSX 10.6's clang (whatever that was) is probably the most
> likely I'd guess.
>
> If we did want to require a newer compiler there are a
> bunch of QEMU_GNUC_PREREQ(3,4) calls that could be
> obsoleted. But we should probably do that as a separate
> thread to get some consensus on what the minimum version
> should be, and put a helpful check in configure and
> a line in the release notes and so on...
We already require 4.1 for atomics.
Paolo
Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__, Markus Armbruster, 2017/01/31
Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__, Peter Maydell, 2017/01/31
Re: [Qemu-devel] [PATCH] QEMU_BUILD_BUG_ON: use __COUNTER__, Daniel P. Berrange, 2017/01/31