Re: [Qemu-devel] [PATCH v2 0/3] Leon3 patches

[KONRAD Frederic]

Le 5/3/19 à 10:19 AM, Mark Cave-Ayland a écrit :
> On 25/04/2019 13:18, KONRAD Frederic wrote:
>
> > Hi all,
> >
> > Those are some little fixes for the leon3 machine:
> >    * The first part initializes the uart and the timer when no bios are
> >      provided.
> >    * The second part adds AHB and APB plug and play devices to allow to boot
> >      linux.
> >    * The third part adds myself to the MAINTAINERS for this board.
> >
> > The test images are available here: https://www.gaisler.com/anonftp/linux/lin
> > ux-2.6/images/leon-linux-4.9/leon-linux-4.9-1.0/up/
> >
> > Tested with:
> >    qemu-system-sparc -M leon3_generic --nographic --kernel image.ram
> >
> > V1 -> V2:
> >    * minor fixes in the first patch suggested by Philippe.
> >
> > Regards,
> > Fred
> >
> > KONRAD Frederic (3):
> >    leon3: add a little bootloader
> >    leon3: introduce the plug and play mecanism
> >    MAINTAINERS: add myself for leon3
> >
> >   MAINTAINERS                         |   1 +
> >   hw/misc/Makefile.objs               |   2 +
> >   hw/misc/grlib_ahb_apb_pnp.c         | 269 ++++++++++++++++++++++++++++++++++++
> >   hw/sparc/leon3.c                    | 114 +++++++++++++--
> >   include/hw/misc/grlib_ahb_apb_pnp.h |  60 ++++++++
> >   include/hw/sparc/grlib.h            |  35 +++--
> >   6 files changed, 455 insertions(+), 26 deletions(-)
> >   create mode 100644 hw/misc/grlib_ahb_apb_pnp.c
> >   create mode 100644 include/hw/misc/grlib_ahb_apb_pnp.h
>
> Hi Frederic,
>
> I've now had a chance to review this - I think it basically looks good, it just 
> needs
> a few minor tweaks. I can also confirm that using the test images at the URL 
> above, I
> can boot to a userspace shell.
>
> I'm happy to take this through my qemu-sparc branch once everything is ready to 
> go.
>
>
> ATB,
>
> Mark.

Hi Mark,

Thanks for the review.

Regards,
Fred