[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] TriCore fixes and gdbstub
From: |
no-reply |
Subject: |
Re: [PATCH 0/5] TriCore fixes and gdbstub |
Date: |
Mon, 30 Sep 2019 07:38:02 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [PATCH 0/5] TriCore fixes and gdbstub
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
e0ab359 target/tricore: Implement gdbstub
af906d6 target/tricore: Implement tricore_cpu_get_phys_page_debug
421ac82 target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep
5a6c845 target/tricore: Move translate feature check to ctx
69f10b4 target/tricore: Don't save pc in generate_qemu_excp
=== OUTPUT BEGIN ===
1/5 Checking commit 69f10b4a4d39 (target/tricore: Don't save pc in
generate_qemu_excp)
2/5 Checking commit 5a6c84545f56 (target/tricore: Move translate feature check
to ctx)
3/5 Checking commit 421ac8270548 (target/tricore: Raise EXCP_DEBUG in
gen_goto_tb() for singlestep)
4/5 Checking commit af906d6437cd (target/tricore: Implement
tricore_cpu_get_phys_page_debug)
5/5 Checking commit e0ab359a6c96 (target/tricore: Implement gdbstub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
WARNING: line over 80 characters
#133: FILE: target/tricore/gdbstub.c:70:
+static void tricore_cpu_gdb_write_csfr(CPUTriCoreState *env, int n, uint32_t
val)
ERROR: spaces required around that '-' (ctx:VxV)
#178: FILE: target/tricore/gdbstub.c:115:
+ return gdb_get_reg32(mem_buf, env->gpr_a[n-16]);
^
ERROR: spaces required around that '-' (ctx:VxV)
#196: FILE: target/tricore/gdbstub.c:133:
+ env->gpr_d[n-16] = tmp;
^
total: 2 errors, 2 warnings, 170 lines checked
Patch 5/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PATCH 0/5] TriCore fixes and gdbstub, Bastian Koppelmann, 2019/09/30
- [PATCH 1/5] target/tricore: Don't save pc in generate_qemu_excp, Bastian Koppelmann, 2019/09/30
- [PATCH 5/5] target/tricore: Implement gdbstub, Bastian Koppelmann, 2019/09/30
- [PATCH 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep, Bastian Koppelmann, 2019/09/30
- [PATCH 2/5] target/tricore: Move translate feature check to ctx, Bastian Koppelmann, 2019/09/30
- [PATCH 4/5] target/tricore: Implement tricore_cpu_get_phys_page_debug, Bastian Koppelmann, 2019/09/30
- Re: [PATCH 0/5] TriCore fixes and gdbstub,
no-reply <=