[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an e
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation |
Date: |
Tue, 17 Mar 2020 07:52:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster <address@hidden> wrote:
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> qapi/qmp-dispatch.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
>> index 112d29a9ab..fb53687ce9 100644
>> --- a/qapi/qmp-dispatch.c
>> +++ b/qapi/qmp-dispatch.c
>> @@ -164,7 +164,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject
>> *request,
>> g_assert(!ret);
>> return NULL;
>> } else if (!ret) {
>> - /* TODO turn into assertion */
>> + /*
>> + * When the command's schema has no 'returns', cmd->fn()
>> + * leaves @ret null. The QMP spec calls for an the empty
>
> "for an"
Fixing, thanks!
> Can we assert that the command's schema has no 'returns' in this case?
Feels impractical. Enforcing "no returns when success-response is
false" is the QAPI schema frontend's job anyway. That's a separate
patch. I can put it on my to-do list.
>> + * object then; supply it.
>> + */
>> ret = QOBJECT(qdict_new());
>> }
>>
>> --
>> 2.21.1
>>
>>
- Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, (continued)
- [PATCH v3 23/34] qapi: Simplify how qmp_dispatch() gets the request ID, Markus Armbruster, 2020/03/15
- [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/15
- [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation, Markus Armbruster, 2020/03/15
- [PATCH v3 32/34] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2020/03/15
- [PATCH v3 16/34] qapi/schema: Change _make_features() to a take feature list, Markus Armbruster, 2020/03/15
- [PATCH v3 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch(), Markus Armbruster, 2020/03/15
- [PATCH v3 08/34] tests/test-qmp-event: Simplify test data setup, Markus Armbruster, 2020/03/15
- [PATCH v3 04/34] docs/devel/qapi-code-gen: Document 'features' introspection, Markus Armbruster, 2020/03/15
- [PATCH v3 30/34] qapi: Implement deprecated-output=hide for QMP event data, Markus Armbruster, 2020/03/15