Re: [PATCH 49/67] ui/vc: split off the VC part from console.c

[Daniel P . Berrangé]

On Mon, Sep 04, 2023 at 04:57:45PM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Sep 1, 2023 at 9:23 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Aug 30, 2023 at 01:38:23PM +0400, marcandre.lureau@redhat.com wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > Move common declarations to console-priv.h, and add a new unit
> > > console-vc.c which will handle VC/chardev rendering, when pixman is
> > > available.
> > >
> > > (if necessary, the move could be done chunk by chunks)
> > >
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > ---
> > >  ui/console-priv.h |   43 ++
> > >  ui/console-vc.c   | 1079 ++++++++++++++++++++++++++++++++++++++++++++
> > >  ui/console.c      | 1096 +--------------------------------------------
> > >  ui/meson.build    |    1 +
> > >  4 files changed, 1126 insertions(+), 1093 deletions(-)
> > >  create mode 100644 ui/console-priv.h
> > >  create mode 100644 ui/console-vc.c
> > >
> > > diff --git a/ui/console-vc.c b/ui/console-vc.c
> > > new file mode 100644
> > > index 0000000000..656f099556
> > > --- /dev/null
> > > +++ b/ui/console-vc.c
> > > @@ -0,0 +1,1079 @@
> > > +/*
> > > + * SPDX-License-Identifier: GPL-2.0-or-later
> > > + * QEMU VC
> >
> > This code is moved out of console.c, which (surprisingly) appears
> > to have an MIT license header.
> >
> 
> updated
> 
> >
> > The include/ui/console.h header meanwhile has no license, so is
> > valid to assume it is GPL-2.0-or-later I guess.
> >
> 
> Do you think I should split this patch in multiple patches? or can you
> r-b it with the license change?

No need to split IMHO. With the MIT license for the .c file,

  Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|