[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 60/67] ui/vnc: VNC requires PIXMAN
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 60/67] ui/vnc: VNC requires PIXMAN |
|
Date: |
Mon, 4 Sep 2023 16:01:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 |
On 8/30/23 11:38, marcandre.lureau@redhat.com wrote:
-if get_option('vnc').allowed() and have_system
+if get_option('vnc') \
+ .disable_auto_if(not pixman.found()) \
+ .require(pixman.found()) \
+ .allowed() and have_system
".disable_auto_if()" is not needed, because ".require()" handles it.
However, please add an error message for ".require()" and make it a seprate
variable:
have_vnc = get_option('vnc') \
.disable_auto_if(not have_system) \
.require(pixman.found(),
error_message: 'cannot enable VNC if pixman is not available') \
.allowed()
Thanks,
Paolo
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 60/67] ui/vnc: VNC requires PIXMAN,
Paolo Bonzini <=