Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

[Paolo Bonzini]

On 8/30/23 14:34, BALATON Zoltan wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > SM501 is going to depend on PIXMAN next.
>
> Why is this patch needed when SM501 is the one that depends on PIXMAN 
> and should pull in the dependency? Also what's the change in 
> default.mak?

The change in default.mak is needed because the default is moved from 
there to hw/ppc/Kconfig.  Without it,

    # configs/devices/ppc-softmmu/default.mak
    CONFIG_SAM460EX=y

    # hw/ppc/Kconfig
    config SAM460EX
        depends on PPC && PIXMAN

fails to compile without pixman, due to a contradiction (default.mak 
requires enabling SAM460EX, hw/ppc/Kconfig requires disabling it because 
CONFIG_PIXMAN=n).

> ati-vga also uses pixman and currently has no fall back. 
> The sm501 already has fallback when pixman fails so could work without 
> pixman too, see x-pixman property in sm501.c.

Yeah, this means there are changes needed in both this patch and ATI.

Paolo