qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] contrib/plugins: add Darwin support


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] contrib/plugins: add Darwin support
Date: Thu, 7 Sep 2023 14:30:44 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 7/9/23 13:44, Paolo Bonzini wrote:
Under Darwin, using -shared makes it impossible to have undefined symbols
and -bundle has to be used instead; so detect the OS and use
different options.

Based-on: <20230907101811.469236-1-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
         This replaces Philippe's patch to link with GLib, and also fixes
         errors like

           "_qemu_plugin_get_hwaddr", referenced from:
              _vcpu_mem in execlog.o

         I guess this shows that we're kinda losing in not using Meson
         for the plugins, but as I said I appreciate the didactic value
         of using a standalone Makefile (with only a handful of lines
         in configure).

  contrib/plugins/Makefile | 4 ++++
  1 file changed, 4 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]