Re: [PATCH RESEND v5 02/57] target/loongarch: Implement gvec_*_vl functions

[Richard Henderson]

On 9/7/23 01:31, Song Gao wrote:
> Using gvec_*_vl functions hides oprsz. We can use gvec_v* for oprsz 16.
> and gvec_v* for oprsz 32.
>
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
>   target/loongarch/insn_trans/trans_vec.c.inc | 68 +++++++++++++--------
>   1 file changed, 44 insertions(+), 24 deletions(-)

The description above is not quite right.  How about:

  Create gvec_*_vl functions in order to hide oprsz.
  This is used by gvec_v* functions for oprsz 16,
  and will be used by gvec_x* functions for oprsz 32.

The code is correct.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~