Re: [PATCH v3 8/8] hw/fsi: Documentation and testing

[Ninad Palsule]

Hello Cedric,

On 8/30/23 02:13, Cédric Le Goater wrote:
> On 8/30/23 09:05, Thomas Huth wrote:
> > On 30/08/2023 04.26, Ninad Palsule wrote:
> > > Added FSI document
> > > Added basic qtests for FSI model.
> > > Added MAINITAINER for FSI
> > > Replaced some qemu logs to traces.
> >
> > Sorry, that's not how we rework patch series in the QEMU development 
> > process. Please squash the log traces changes into the patches that 
> > introduced the original code, and please put the MAINTAINERS update, 
> > documentation and qtests into separate patches.
>
> yes. This is true for some Kconfig changes also. On that topic, please
> make sure FSI is compiled only when ASPEED_SOC is selected. It could be
> useful for the PPC PowerNV machines one day but the models are not
> available yet.

Fixed the Kconfig rework and make sure that FSI is selected only with 
ASPEED_SOC.


Thanks for the review.

~Ninad

> I will try to go through the series this week. Wait a bit for the v4.
>
> Thanks,
>
> C.