[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 01/10] migration: Fix possible race when setting rp_state.erro
From: |
Fabiano Rosas |
Subject: |
[PATCH v6 01/10] migration: Fix possible race when setting rp_state.error |
Date: |
Mon, 11 Sep 2023 14:13:11 -0300 |
We don't need to set the rp_state.error right after a shutdown because
qemu_file_shutdown() always sets the QEMUFile error, so the return
path thread would have seen it and set the rp error itself.
Setting the error outside of the thread is also racy because the
thread could clear it after we set it.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 5528acb65e..f88c86079c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2062,7 +2062,6 @@ static int
await_return_path_close_on_source(MigrationState *ms)
* waiting for the destination.
*/
qemu_file_shutdown(ms->rp_state.from_dst_file);
- mark_source_rp_bad(ms);
}
trace_await_return_path_close_on_source_joining();
qemu_thread_join(&ms->rp_state.rp_thread);
--
2.35.3
- [PATCH v6 00/10] Fix segfault on migration return path, Fabiano Rosas, 2023/09/11
- [PATCH v6 02/10] migration: Fix possible races when shutting down the return path, Fabiano Rosas, 2023/09/11
- [PATCH v6 01/10] migration: Fix possible race when setting rp_state.error,
Fabiano Rosas <=
- [PATCH v6 05/10] migration: Consolidate return path closing code, Fabiano Rosas, 2023/09/11
- [PATCH v6 03/10] migration: Fix possible race when shutting down to_dst_file, Fabiano Rosas, 2023/09/11
- [PATCH v6 06/10] migration: Replace the return path retry logic, Fabiano Rosas, 2023/09/11
- [PATCH v6 07/10] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/09/11
- [PATCH v6 08/10] migration/yank: Use channel features, Fabiano Rosas, 2023/09/11
- [PATCH v6 04/10] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/09/11
- [PATCH v6 09/10] migration/yank: Keep track of registered yank instances, Fabiano Rosas, 2023/09/11