qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/24] target/*: Use __alignof not __alignof__


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 04/24] target/*: Use __alignof not __alignof__
Date: Thu, 14 Sep 2023 08:01:43 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 14/9/23 04:44, Richard Henderson wrote:
No functional change, just using a common spelling.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/arm/cpu.c      | 2 +-
  target/ppc/cpu_init.c | 2 +-
  target/s390x/cpu.c    | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)

Why this one and not the other?

$ git grep -w __alignof__ | wc -l
      21
$ git grep -w __alignof | wc -l
       5

In particular:

include/qom/object.h:298: .instance_align = __alignof__(ModuleObjName), \

If we have a preference, we should clean tree-wide.

Regardless,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]