[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 38/39] accel/tcg: Have tcg_exec_realizefn() return a boolean
From: |
Richard Henderson |
Subject: |
[PATCH v3 38/39] accel/tcg: Have tcg_exec_realizefn() return a boolean |
Date: |
Sat, 16 Sep 2023 14:41:22 -0700 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Following the example documented since commit e3fe3988d7 ("error:
Document Error API usage rules"), have tcg_exec_realizefn() return
a boolean indicating whether an error is set or not.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230915190009.68404-5-philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu-all.h | 2 +-
accel/tcg/cpu-exec.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
index 8d262d141e..6c1db14842 100644
--- a/include/exec/cpu-all.h
+++ b/include/exec/cpu-all.h
@@ -410,7 +410,7 @@ static inline bool tlb_hit(uint64_t tlb_addr, vaddr addr)
/* accel/tcg/cpu-exec.c */
int cpu_exec(CPUState *cpu);
-void tcg_exec_realizefn(CPUState *cpu, Error **errp);
+bool tcg_exec_realizefn(CPUState *cpu, Error **errp);
void tcg_exec_unrealizefn(CPUState *cpu);
/* Validate correct placement of CPUArchState. */
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 95dd8a30cb..fd0fc08f76 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -1089,7 +1089,7 @@ int cpu_exec(CPUState *cpu)
return ret;
}
-void tcg_exec_realizefn(CPUState *cpu, Error **errp)
+bool tcg_exec_realizefn(CPUState *cpu, Error **errp)
{
static bool tcg_target_initialized;
CPUClass *cc = CPU_GET_CLASS(cpu);
@@ -1105,6 +1105,8 @@ void tcg_exec_realizefn(CPUState *cpu, Error **errp)
tcg_iommu_init_notifier_list(cpu);
#endif /* !CONFIG_USER_ONLY */
/* qemu_plugin_vcpu_init_hook delayed until cpu_index assigned. */
+
+ return true;
}
/* undo the initializations in reverse order */
--
2.34.1
- [PATCH v3 11/39] tcg: Rename cpu_env to tcg_env, (continued)
- [PATCH v3 11/39] tcg: Rename cpu_env to tcg_env, Richard Henderson, 2023/09/16
- [PATCH v3 12/39] accel/tcg: Replace CPUState.env_ptr with cpu_env(), Richard Henderson, 2023/09/16
- [PATCH v3 13/39] accel/tcg: Remove cpu_set_cpustate_pointers, Richard Henderson, 2023/09/16
- [PATCH v3 21/39] accel/tcg: Remove env_tlb(), Richard Henderson, 2023/09/16
- [PATCH v3 18/39] accel/tcg: Modify memory access functions to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 28/39] accel: Rename accel-common.c -> accel-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 24/39] exec: Make EXCP_FOO definitions target agnostic, Richard Henderson, 2023/09/16
- [PATCH v3 26/39] accel/tcg: Restrict dump_exec_info() declaration, Richard Henderson, 2023/09/16
- [PATCH v3 29/39] exec: Rename cpu.c -> cpu-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 33/39] accel/tcg: Make icount.o a target agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 38/39] accel/tcg: Have tcg_exec_realizefn() return a boolean,
Richard Henderson <=
- [PATCH v3 19/39] accel/tcg: Modify atomic_mmu_lookup() to use CPUState, Richard Henderson, 2023/09/16
- [PATCH v3 30/39] exec: Rename target specific page-vary.c -> page-vary-target.c, Richard Henderson, 2023/09/16
- [PATCH v3 32/39] accel/tcg: Make monitor.c a target-agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 35/39] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize(), Richard Henderson, 2023/09/16
- [PATCH v3 34/39] accel/tcg: Make cpu-exec-common.c a target agnostic unit, Richard Henderson, 2023/09/16
- [PATCH v3 20/39] accel/tcg: Use CPUState in atomicity helpers, Richard Henderson, 2023/09/16
- [PATCH v3 27/39] accel: Make accel-blocker.o target agnostic, Richard Henderson, 2023/09/16
- [PATCH v3 31/39] accel/tcg: Rename target-specific 'internal.h' -> 'internal-target.h', Richard Henderson, 2023/09/16
- [PATCH v3 36/39] accel: Introduce accel_cpu_unrealize() stub, Richard Henderson, 2023/09/16