Re: [PATCH 09/52] migration/rdma: Put @errp parameter last

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/52] migration/rdma: Put @errp parameter last

From:	Fabiano Rosas
Subject:	Re: [PATCH 09/52] migration/rdma: Put @errp parameter last
Date:	Mon, 18 Sep 2023 14:17:23 -0300

Markus Armbruster <armbru@redhat.com> writes:

> include/qapi/error.h demands:
>
>  * - Functions that use Error to report errors have an Error **errp
>  *   parameter.  It should be the last parameter, except for functions
>  *   taking variable arguments.
>
> qemu_rdma_connect() does not conform.  Clean it up.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 11/52] migration/rdma: Drop rdma_add_block() error handling, (continued)
- [PATCH 34/52] migration/rdma: Convert qemu_rdma_exchange_recv() to Error, Markus Armbruster, 2023/09/18
  - Re: [PATCH 34/52] migration/rdma: Convert qemu_rdma_exchange_recv() to Error, Zhijian Li (Fujitsu), 2023/09/25
- [PATCH 30/52] migration/rdma: Delete inappropriate error_report() in macro ERROR(), Markus Armbruster, 2023/09/18
  - Re: [PATCH 30/52] migration/rdma: Delete inappropriate error_report() in macro ERROR(), Zhijian Li (Fujitsu), 2023/09/25
- [PATCH 14/52] migration/rdma: Use bool for two RDMAContext flags, Markus Armbruster, 2023/09/18
  - Re: [PATCH 14/52] migration/rdma: Use bool for two RDMAContext flags, Fabiano Rosas, 2023/09/18
  - Re: [PATCH 14/52] migration/rdma: Use bool for two RDMAContext flags, Zhijian Li (Fujitsu), 2023/09/22
- [PATCH 09/52] migration/rdma: Put @errp parameter last, Markus Armbruster, 2023/09/18
  - Re: [PATCH 09/52] migration/rdma: Put @errp parameter last, Fabiano Rosas <=
  - Re: [PATCH 09/52] migration/rdma: Put @errp parameter last, Zhijian Li (Fujitsu), 2023/09/21
- [PATCH 03/52] migration/rdma: Clean up rdma_delete_block()'s return type, Markus Armbruster, 2023/09/18
  - Re: [PATCH 03/52] migration/rdma: Clean up rdma_delete_block()'s return type, Fabiano Rosas, 2023/09/18
  - Re: [PATCH 03/52] migration/rdma: Clean up rdma_delete_block()'s return type, Zhijian Li (Fujitsu), 2023/09/21
- [PATCH 40/52] migration/rdma: Convert qemu_rdma_write() to Error, Markus Armbruster, 2023/09/18
  - Re: [PATCH 40/52] migration/rdma: Convert qemu_rdma_write() to Error, Zhijian Li (Fujitsu), 2023/09/26
- [PATCH 28/52] migration/rdma: Check negative error values the same way everywhere, Markus Armbruster, 2023/09/18
  - Re: [PATCH 28/52] migration/rdma: Check negative error values the same way everywhere, Zhijian Li (Fujitsu), 2023/09/25
    - Re: [PATCH 28/52] migration/rdma: Check negative error values the same way everywhere, Markus Armbruster, 2023/09/25
- [PATCH 37/52] migration/rdma: Convert qemu_rdma_reg_whole_ram_blocks() to Error, Markus Armbruster, 2023/09/18

Prev by Date: Re: [PATCH 08/52] migration/rdma: Fix qemu_rdma_accept() to return failure on errors
Next by Date: Re: [PATCH 2/3] qga: Add optional stream-output argument to guest-exec
Previous by thread: [PATCH 09/52] migration/rdma: Put @errp parameter last
Next by thread: Re: [PATCH 09/52] migration/rdma: Put @errp parameter last
Index(es):
- Date
- Thread