[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/8] migration: Fix possible race when setting rp_state.error
From: |
Fabiano Rosas |
Subject: |
[PATCH 2/8] migration: Fix possible race when setting rp_state.error |
Date: |
Mon, 18 Sep 2023 14:28:16 -0300 |
We don't need to set the rp_state.error right after a shutdown because
qemu_file_shutdown() always sets the QEMUFile error, so the return
path thread would have seen it and set the rp error itself.
Setting the error outside of the thread is also racy because the
thread could clear it after we set it.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/migration.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 3ee1e6b0d6..d426b69ada 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2074,7 +2074,6 @@ static int
await_return_path_close_on_source(MigrationState *ms)
* waiting for the destination.
*/
qemu_file_shutdown(ms->rp_state.from_dst_file);
- mark_source_rp_bad(ms);
}
trace_await_return_path_close_on_source_joining();
qemu_thread_join(&ms->rp_state.rp_thread);
--
2.35.3
- [PATCH 0/8] migration fixes, Fabiano Rosas, 2023/09/18
- [PATCH 1/8] migration: Fix race that dest preempt thread close too early, Fabiano Rosas, 2023/09/18
- [PATCH 4/8] migration: Fix possible race when shutting down to_dst_file, Fabiano Rosas, 2023/09/18
- [PATCH 2/8] migration: Fix possible race when setting rp_state.error,
Fabiano Rosas <=
- [PATCH 3/8] migration: Fix possible races when shutting down the return path, Fabiano Rosas, 2023/09/18
- [PATCH 5/8] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/09/18
- [PATCH 6/8] migration: Consolidate return path closing code, Fabiano Rosas, 2023/09/18
- [PATCH 7/8] migration: Replace the return path retry logic, Fabiano Rosas, 2023/09/18
- [PATCH 8/8] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/09/18
- Re: [PATCH 0/8] migration fixes, Fabiano Rosas, 2023/09/27
- Re: [PATCH 0/8] migration fixes, Stefan Hajnoczi, 2023/09/27
- Re: [PATCH 0/8] migration fixes, Stefan Hajnoczi, 2023/09/27