qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 07/21] i386/pc: Drop pc_machine_kvm_type()


From: Xiaoyao Li
Subject: Re: [RFC PATCH v2 07/21] i386/pc: Drop pc_machine_kvm_type()
Date: Fri, 22 Sep 2023 08:24:18 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.1

On 9/21/2023 4:51 PM, David Hildenbrand wrote:
On 14.09.23 05:51, Xiaoyao Li wrote:
pc_machine_kvm_type() was introduced by commit e21be724eaf5 ("i386/xen:
add pc_machine_kvm_type to initialize XEN_EMULATE mode") to do Xen
specific initialization by utilizing kvm_type method.

commit eeedfe6c6316 ("hw/xen: Simplify emulated Xen platform init")
moves the Xen specific initialization to pc_basic_device_init().

There is no need to keep the PC specific kvm_type() implementation
anymore.

So we'll fallback to kvm_arch_get_default_type(), which simply returns 0.

On the other hand, later patch will implement kvm_type()
method for all x86/i386 machines to support KVM_X86_SW_PROTECTED_VM.


^ I suggest dropping that and merging that patch ahead-of-time as a simple cleanup.

I suppose the "that" here means "this patch", right?

If so, I can submit this patch separately.

Reviewed-by: David Hildenbrand <david@redhat.com>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]