Re: [RFC PATCH v2 07/21] i386/pc: Drop pc_machine_kvm_type()

[David Hildenbrand]

On 22.09.23 02:24, Xiaoyao Li wrote:
> On 9/21/2023 4:51 PM, David Hildenbrand wrote:
> > On 14.09.23 05:51, Xiaoyao Li wrote:
> > > pc_machine_kvm_type() was introduced by commit e21be724eaf5 ("i386/xen:
> > > add pc_machine_kvm_type to initialize XEN_EMULATE mode") to do Xen
> > > specific initialization by utilizing kvm_type method.
> > >
> > > commit eeedfe6c6316 ("hw/xen: Simplify emulated Xen platform init")
> > > moves the Xen specific initialization to pc_basic_device_init().
> > >
> > > There is no need to keep the PC specific kvm_type() implementation
> > > anymore.
> >
> > So we'll fallback to kvm_arch_get_default_type(), which simply returns 0.
> >
> > > On the other hand, later patch will implement kvm_type()
> > > method for all x86/i386 machines to support KVM_X86_SW_PROTECTED_VM.
> >
> > ^ I suggest dropping that and merging that patch ahead-of-time as a
> > simple cleanup.
>
> I suppose the "that" here means "this patch", right?


With that I meant that paragraph "On the other hand, later patch ...".

--
Cheers,

David / dhildenb