[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] multifd: fix counters in multifd_send_thread
|
From: |
Fabiano Rosas |
|
Subject: |
Re: [PATCH 3/4] multifd: fix counters in multifd_send_thread |
|
Date: |
Fri, 22 Sep 2023 15:13:38 -0300 |
Elena Ufimtseva <elena.ufimtseva@oracle.com> writes:
> Previous commit cbec7eb76879d419e7dbf531ee2506ec0722e825
> "migration/multifd: Compute transferred bytes correctly"
> removed accounting for packet_len in non-rdma
> case, but the next_packet_size only accounts for pages, not for
> the header packet (normal_pages * PAGE_SIZE) that is being sent
> as iov[0]. The packet_len part should be added to account for
> the size of MultiFDPacket and the array of the offsets.
>
> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
I don't really understand the purpose of next_packet_size, but the
accounting and explanation seem correct.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
- [PATCH 0/4] multifd: various fixes, Elena Ufimtseva, 2023/09/22
- [PATCH 1/4] multifd: wait for channels_ready before sending sync, Elena Ufimtseva, 2023/09/22
- [PATCH 3/4] multifd: fix counters in multifd_send_thread, Elena Ufimtseva, 2023/09/22
- Re: [PATCH 3/4] multifd: fix counters in multifd_send_thread,
Fabiano Rosas <=
- [PATCH 4/4] multifd: reset next_packet_len after sending pages, Elena Ufimtseva, 2023/09/22
- [PATCH 2/4] migration: check for rate_limit_max for RATE_LIMIT_DISABLED, Elena Ufimtseva, 2023/09/22
- Re: [PATCH 0/4] multifd: various fixes, Fabiano Rosas, 2023/09/22