Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for ci

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for ci

From:	Michael Tokarev
Subject:	Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid
Date:	Mon, 25 Sep 2023 23:04:49 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

25.09.2023 22:40, Vladimir Sementsov-Ogievskiy wrote:

NVMeQueuePair::reqs as length NVME_NUM_REQS, which less than
NVME_QUEUE_SIZE by 1.

+        if (cid == 0 || cid > NVME_NUM_REQS) {
+            warn_report("NVMe: Unexpected CID in completion queue: %" PRIu32
+                        ", should be within is: 1..%u", cid, NVME_NUM_REQS);


 - is: I guess :)

/mjt

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 01/12] hw/core/loader: load_at(): check size, (continued)
- [PATCH 03/12] util/filemonitor-inotify: qemu_file_monitor_watch(): avoid overflow, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 03/12] util/filemonitor-inotify: qemu_file_monitor_watch(): avoid overflow, Peter Maydell, 2023/09/26
- [PATCH 05/12] device_tree: qmp_dumpdtb(): stronger assertion, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 05/12] device_tree: qmp_dumpdtb(): stronger assertion, Alistair Francis, 2023/09/25
    - Re: [PATCH 05/12] device_tree: qmp_dumpdtb(): stronger assertion, Vladimir Sementsov-Ogievskiy, 2023/09/26
  - Re: [PATCH 05/12] device_tree: qmp_dumpdtb(): stronger assertion, Peter Maydell, 2023/09/26
- [PATCH 06/12] mc146818rtc: rtc_set_time(): initialize tm to zeroes, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 06/12] mc146818rtc: rtc_set_time(): initialize tm to zeroes, Peter Maydell, 2023/09/26
- [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid, Michael Tokarev <=
  - Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid, Peter Maydell, 2023/09/26
- [PATCH 07/12] pcie_sriov: unregister_vfs(): fix error path, Vladimir Sementsov-Ogievskiy, 2023/09/25
- [PATCH 10/12] hw/core/loader: gunzip(): initialize z_stream, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 10/12] hw/core/loader: gunzip(): initialize z_stream, Peter Maydell, 2023/09/26
- [PATCH 11/12] hw/core/loader: read_targphys(): add upper bound, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 11/12] hw/core/loader: read_targphys(): add upper bound, Michael Tokarev, 2023/09/25
    - Re: [PATCH 11/12] hw/core/loader: read_targphys(): add upper bound, Vladimir Sementsov-Ogievskiy, 2023/09/26
  - Re: [PATCH 11/12] hw/core/loader: read_targphys(): add upper bound, Peter Maydell, 2023/09/26
- [PATCH 12/12] io/channel-socket: qio_channel_socket_flush(): improve msg validation, Vladimir Sementsov-Ogievskiy, 2023/09/25
  - Re: [PATCH 12/12] io/channel-socket: qio_channel_socket_flush(): improve msg validation, Maksim Davydov, 2023/09/26

Prev by Date: RE: [PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch
Next by Date: Re: [PATCH 11/12] hw/core/loader: read_targphys(): add upper bound
Previous by thread: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid
Next by thread: Re: [PATCH 08/12] block/nvme: nvme_process_completion() fix bound for cid
Index(es):
- Date
- Thread