[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errore
|
From: |
Zhijian Li (Fujitsu) |
|
Subject: |
Re: [PATCH 26/52] migration/rdma: Replace int error_state by bool errored |
|
Date: |
Tue, 26 Sep 2023 10:18:12 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 25/09/2023 15:09, Markus Armbruster wrote:
> "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com> writes:
>
>> On 18/09/2023 22:41, Markus Armbruster wrote:
>>> All we do with the value of RDMAContext member @error_state is test
>>> whether it's zero. Change to bool and rename to @errored.
>>>
>>
>> make sense!
>>
>> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
>>
>> Can we move this patch ahead "[PATCH 23/52] migration/rdma: Clean up
>> qemu_rdma_wait_comp_channel()'s error value",
>> so that [23/52] [24/52] [25/52] will be more easy to review.
>
> I think I could squash PATCH 23 into "[PATCH 25/52] migration/rdma: Dumb
> down remaining int error values to -1". Would that work for you?
Yeah~, thank you
>