Re: [PATCH] maint: Tweak comment in mailmap to sound friendlier

[Peter Maydell]

On Tue, 26 Sept 2023 at 21:41, <eblake@redhat.com> wrote:
>
> From: Eric Blake <eblake@redhat.com>
>
> Documenting that we should not add new lines to work around SPF
> rewrites sounds foreboding; the intent is instead that new lines here
> are okay, but indicate a second problem elsewhere in our build process
> that we should also consider fixing at the same time, to keep the
> section from growing without bounds.
>
> Mentioning DMARC alongside SPF may also help people grep for this
> scenario, as well as documenting the 'git config' workaround that can
> be used by submitters to avoid the munging issue in the first place.
>
> Fixes: 3bd2608d ("maint: Add .mailmap entries for patches claiming list 
> authorship")
> CC: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> I'm sending this email with a temporary 'git config sendemail.from
> eblake@redhat.com', to see if the added advice actually adds the extra
> line. It did not show up in my editor window, though, so this patch
> may need further tweaking to get the instructions right.  Since I
> don't normally suffer from SPF/DMARC munging, I may not be the best
> person to test the right workaround.  Or maybe 'git config' does not
> yet have the right workaround already available as a turnkey solution
> we can suggest.

Well, the From: line appeared in my copy of the email, so I guess it works.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM