qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PULL 56/56] disas/m68k: clean up local variable shadowing


From: Markus Armbruster
Subject: [PULL 56/56] disas/m68k: clean up local variable shadowing
Date: Fri, 29 Sep 2023 10:50:53 +0200

From: Laurent Vivier <laurent@vivier.eu>

Fix following warnings

.../disas/m68k.c: In function ‘print_insn_arg’:
.../disas/m68k.c:1635:13: warning: declaration of ‘val’ shadows a previous 
local [-Wshadow=compatible-local]
 1635 |         int val = fetch_arg (buffer, place, 5, info);
      |             ^~~
.../disas/m68k.c:1093:7: note: shadowed declaration is here
 1093 |   int val = 0;
      |       ^~~

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Message-ID: <20230925084455.395150-1-laurent@vivier.eu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 disas/m68k.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/disas/m68k.c b/disas/m68k.c
index aefaecfbd6..1f16e295ab 100644
--- a/disas/m68k.c
+++ b/disas/m68k.c
@@ -1632,10 +1632,10 @@ print_insn_arg (const char *d,
     case '2':
     case '3':
       {
-       int val = fetch_arg (buffer, place, 5, info);
+       int reg = fetch_arg (buffer, place, 5, info);
         const char *name = 0;
 
-       switch (val)
+       switch (reg)
          {
          case 2: name = "%tt0"; break;
          case 3: name = "%tt1"; break;
@@ -1655,12 +1655,12 @@ print_insn_arg (const char *d,
              int break_reg = ((buffer[3] >> 2) & 7);
 
              (*info->fprintf_func)
-               (info->stream, val == 0x1c ? "%%bad%d" : "%%bac%d",
+               (info->stream, reg == 0x1c ? "%%bad%d" : "%%bac%d",
                 break_reg);
            }
            break;
          default:
-           (*info->fprintf_func) (info->stream, "<mmu register %d>", val);
+           (*info->fprintf_func) (info->stream, "<mmu register %d>", reg);
          }
        if (name)
          (*info->fprintf_func) (info->stream, "%s", name);
-- 
2.41.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]