Re: [PATCH 08/10] tcg/ppc: Use tcg_use_softmmu

[Philippe Mathieu-Daudé]

On 3/10/23 19:43, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/ppc/tcg-target.c.inc | 284 ++++++++++++++++++++-------------------
>   1 file changed, 143 insertions(+), 141 deletions(-)
>
> diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc
> index 90d76c2c2c..e378233568 100644
> --- a/tcg/ppc/tcg-target.c.inc
> +++ b/tcg/ppc/tcg-target.c.inc
> @@ -103,9 +103,7 @@
>   
>   #define have_isel  (cpuinfo & CPUINFO_ISEL)
>   
> -#ifndef CONFIG_SOFTMMU
> -#define TCG_GUEST_BASE_REG 30
> -#endif
> +#define TCG_GUEST_BASE_REG  TCG_REG_R30

Unrelated cleanup, maybe mention it? Otherwise,

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>