[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 07/16] qemu-io: Clean up global variable shadowing
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 07/16] qemu-io: Clean up global variable shadowing |
Date: |
Wed, 4 Oct 2023 14:00:10 +0200 |
Fix:
qemu-io.c:478:36: error: declaration shadows a variable in the global scope
[-Werror,-Wshadow]
static void add_user_command(char *optarg)
^
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/getopt.h:77:14:
note: previous declaration is here
extern char *optarg; /* getopt(3) external variables */
^
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
qemu-io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 2bd7bfb650..050c70835f 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -475,10 +475,10 @@ static int command_loop(void)
return last_error;
}
-static void add_user_command(char *optarg)
+static void add_user_command(char *user_cmd)
{
cmdline = g_renew(char *, cmdline, ++ncmdline);
- cmdline[ncmdline-1] = optarg;
+ cmdline[ncmdline - 1] = user_cmd;
}
static void reenable_tty_echo(void)
--
2.41.0
- Re: [PATCH v3 09/16] semihosting: Clean up global variable shadowing, (continued)
- [PATCH v3 12/16] util/guest-random: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 15/16] sysemu/tpm: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 03/16] net/net: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 06/16] qemu-img: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 07/16] qemu-io: Clean up global variable shadowing,
Philippe Mathieu-Daudé <=
- [PATCH v3 10/16] ui/cocoa: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 11/16] util/cutils: Clean up global variable shadowing in get_relocated_path(), Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 14/16] softmmu/vl: Clean up global variable shadowing, Philippe Mathieu-Daudé, 2023/10/04
- [PATCH v3 13/16] semihosting/arm-compat: Clean up local variable shadowing, Philippe Mathieu-Daudé, 2023/10/04