Re: [PATCH v3 13/15] vfio/common: Store the parent container in VFIODevice

[Cédric Le Goater]

Hello Eric,


> > > @@ -2664,7 +2665,12 @@ void vfio_detach_device(VFIODevice *vbasedev)
> > >    {
> > >        VFIOGroup *group = vbasedev->group;
> > >    +    if (!vbasedev->container) {
> > > +        return;
> > > +    }
> >
> > Can this happen ? Should it be an assert ?
>
> I don't think so. Let me simply drop the check.

the device-introspect-test needs it. No need to resend a v5, I can add it
back in v4 if you are ok with that.


Thanks,

C.