[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/10] qemufile: Always return a verbose error
From: |
Peter Xu |
Subject: |
[PATCH v3 05/10] qemufile: Always return a verbose error |
Date: |
Wed, 4 Oct 2023 18:02:35 -0400 |
There're a lot of cases where we only have an errno set in last_error but
without a detailed error description. When this happens, try to generate
an error contains the errno as a descriptive error.
This will be helpful in cases where one relies on the Error*. E.g.,
migration state only caches Error* in MigrationState.error. With this,
we'll display correct error messages in e.g. query-migrate when the error
was only set by qemu_file_set_error().
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/qemu-file.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index ffa9c0a48a..c12a905a34 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -142,15 +142,24 @@ void qemu_file_set_hooks(QEMUFile *f, const QEMUFileHooks
*hooks)
*
* Return negative error value if there has been an error on previous
* operations, return 0 if no error happened.
- * Optional, it returns Error* in errp, but it may be NULL even if return value
- * is not 0.
*
+ * If errp is specified, a verbose error message will be copied over.
*/
int qemu_file_get_error_obj(QEMUFile *f, Error **errp)
{
+ if (!f->last_error) {
+ return 0;
+ }
+
+ /* There is an error */
if (errp) {
- *errp = f->last_error_obj ? error_copy(f->last_error_obj) : NULL;
+ if (f->last_error_obj) {
+ *errp = error_copy(f->last_error_obj);
+ } else {
+ error_setg_errno(errp, -f->last_error, "Channel error");
+ }
}
+
return f->last_error;
}
--
2.41.0
- [PATCH v3 00/10] migration: Better error handling in rp thread, allow failures in recover, Peter Xu, 2023/10/04
- [PATCH v3 02/10] migration: Introduce migrate_has_error(), Peter Xu, 2023/10/04
- [PATCH v3 07/10] migration: Add migration_rp_wait|kick(), Peter Xu, 2023/10/04
- [PATCH v3 05/10] qemufile: Always return a verbose error,
Peter Xu <=
- [PATCH v3 06/10] migration: Remember num of ramblocks to sync during recovery, Peter Xu, 2023/10/04
- [PATCH v3 08/10] migration: Allow network to fail even during recovery, Peter Xu, 2023/10/04
- [PATCH v3 03/10] migration: Refactor error handling in source return path, Peter Xu, 2023/10/04
- Re: [PATCH v3 03/10] migration: Refactor error handling in source return path, Juan Quintela, 2023/10/05