[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instea
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 52/53] migration/rdma: Use error_report() & friends instead of stderr |
|
Date: |
Thu, 05 Oct 2023 09:24:40 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> wrote:
> error_report() obeys -msg, reports the current error location if any,
> and reports to the current monitor if any. Reporting to stderr
> directly with fprintf() or perror() is wrong, because it loses all
> this.
>
> Fix the offenders. Bonus: resolves a FIXME about problematic use of
> errno.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
I fixed the WARN issue by hand.
Reviewed-by: Juan Quintela <quintela@redhat.com>