[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/10] migration: Display error in query-migrate irrelevan
From: |
Juan Quintela |
Subject: |
Re: [PATCH v3 01/10] migration: Display error in query-migrate irrelevant of status |
Date: |
Thu, 05 Oct 2023 09:28:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Peter Xu <peterx@redhat.com> wrote:
> Display it as long as being set, irrelevant of FAILED status. E.g., it may
> also be applicable to PAUSED stage of postcopy, to provide hint on what has
> gone wrong.
>
> The error_mutex seems to be overlooked when referencing the error, add it
> to be very safe.
>
> This will change QAPI behavior by showing up error message outside !FAILED
> status, but it's intended and doesn't expect to break anyone.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2018404
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, (continued)
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Fabiano Rosas, 2023/10/05
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Peter Xu, 2023/10/05
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Fabiano Rosas, 2023/10/05
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Peter Xu, 2023/10/05
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Fabiano Rosas, 2023/10/05
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Fabiano Rosas, 2023/10/09
- Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER, Peter Xu, 2023/10/10
[PATCH v3 09/10] migration: Allow RECOVER->PAUSED convertion for dest qemu, Peter Xu, 2023/10/04
[PATCH v3 01/10] migration: Display error in query-migrate irrelevant of status, Peter Xu, 2023/10/04
- Re: [PATCH v3 01/10] migration: Display error in query-migrate irrelevant of status,
Juan Quintela <=