Re: [PATCH v2] coverity: physmem: use simple assertions instead of modelling

[Vladimir Sementsov-Ogievskiy]

On 06.10.23 13:27, Vladimir Sementsov-Ogievskiy wrote:
> On 06.10.23 01:53, Paolo Bonzini wrote:
> > On Thu, Oct 5, 2023 at 4:04 PM Vladimir Sementsov-Ogievskiy
> > <vsementsov@yandex-team.ru> wrote:
> > > +            /*
> > > +             * Assure Coverity (and ourselves) that we are not going to OVERRUN
> > > +             * the buffer by following ldn_he_p().
> > > +             */
> > > +            assert((l == 1 && len >= 1) ||
> > > +                   (l == 2 && len >= 2) ||
> > > +                   (l == 4 && len >= 4) ||
> > > +                   (l == 8 && len >= 8));
> >
> > I'll queue it shortly, but perhaps you can try if assert(l <= len) is enough?
> >
> > Alternatively I can try applying the patch on top of the tree that we
> > test with, and see how things go.
>
> I've now made 4 runs:
>
> master:

I wanted to write:

master: 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d

> patched = master + this patch
> l_len = master + this patch, but reduce assertion to assert(l <= len)


also, cov-build version:
cov-build 2023.3.2 (build 865d3107dd p-2023.3-push-63)


--
Best regards,
Vladimir