[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/25] contrib/plugins: fix coverity warning in hotblocks
From: |
Alex Bennée |
Subject: |
[PULL 25/25] contrib/plugins: fix coverity warning in hotblocks |
Date: |
Wed, 11 Oct 2023 11:33:29 +0100 |
Coverity complains that we have an unbalance use of mutex leading to
potential deadlocks.
Fixes: CID 1519048
Fixes: a208ba09bd ("tests/plugin: add a hotblocks plugin")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231009164104.369749-26-alex.bennee@linaro.org>
diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c
index 6b74d25fea..4de1b13494 100644
--- a/contrib/plugins/hotblocks.c
+++ b/contrib/plugins/hotblocks.c
@@ -69,8 +69,8 @@ static void plugin_exit(qemu_plugin_id_t id, void *p)
}
g_list_free(it);
- g_mutex_unlock(&lock);
}
+ g_mutex_unlock(&lock);
qemu_plugin_outs(report->str);
}
--
2.39.2
- [PULL 09/25] gdbstub: Fix target.xml response, (continued)
- [PULL 09/25] gdbstub: Fix target.xml response, Alex Bennée, 2023/10/11
- [PULL 06/25] configure: allow user to override docker engine, Alex Bennée, 2023/10/11
- [PULL 20/25] accel/tcg: Add plugin_enabled to DisasContextBase, Alex Bennée, 2023/10/11
- [PULL 15/25] gdbstub: Use g_markup_printf_escaped(), Alex Bennée, 2023/10/11
- [PULL 03/25] tests/lcitool: add swtpm to the package list, Alex Bennée, 2023/10/11
- [PULL 07/25] configure: remove gcc version suffixes, Alex Bennée, 2023/10/11
- [PULL 11/25] contrib/plugins: Use GRWLock in execlog, Alex Bennée, 2023/10/11
- [PULL 12/25] gdbstub: Introduce GDBFeature structure, Alex Bennée, 2023/10/11
- [PULL 17/25] target/ppc: Remove references to gdb_has_xml, Alex Bennée, 2023/10/11
- [PULL 23/25] contrib/plugins: fix coverity warning in cache, Alex Bennée, 2023/10/11
- [PULL 25/25] contrib/plugins: fix coverity warning in hotblocks,
Alex Bennée <=
- [PULL 16/25] target/arm: Remove references to gdb_has_xml, Alex Bennée, 2023/10/11
- [PULL 21/25] target/sh4: Disable decode_gusa when plugins enabled, Alex Bennée, 2023/10/11
- [PULL 18/25] gdbstub: Remove gdb_has_xml variable, Alex Bennée, 2023/10/11
- [PULL 24/25] contrib/plugins: fix coverity warning in lockstep, Alex Bennée, 2023/10/11
- [PULL 22/25] plugins: Set final instruction count in plugin_gen_tb_end, Alex Bennée, 2023/10/11
- Re: [PULL 00/25] testing, gdbstub and plugin updates, Stefan Hajnoczi, 2023/10/11