[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/6] migration: Fix analyze-migration read operation signe
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness |
Date: |
Wed, 11 Oct 2023 15:24:33 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Fabiano Rosas <farosas@suse.de> wrote:
> The migration code uses unsigned values for 16, 32 and 64-bit
> operations. Fix the script to do the same.
>
> This was causing an issue when parsing the migration stream generated
> on the ppc64 target because one of instance_ids was larger than the
> 32bit signed maximum:
>
> Traceback (most recent call last):
> File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 658,
> in <module>
> dump.read(dump_memory = args.memory)
> File "/home/fabiano/kvm/qemu/build/scripts/analyze-migration.py", line 592,
> in read
> classdesc = self.section_classes[section_key]
> KeyError: ('spapr_iommu', -2147483648)
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
- Re: [PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing, (continued)
- [PATCH v2 1/6] migration: Add the configuration vmstate to the json writer, Fabiano Rosas, 2023/10/09
- [PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py, Fabiano Rosas, 2023/10/09
- [PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used, Fabiano Rosas, 2023/10/09
- [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness, Fabiano Rosas, 2023/10/09
- Re: [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness,
Juan Quintela <=
- [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script, Fabiano Rosas, 2023/10/09
- Re: [PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test, Fabiano Rosas, 2023/10/10