[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH v2 1/9] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable |
|
Date: |
Wed, 11 Oct 2023 16:32:55 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Thomas Huth <thuth@redhat.com> wrote:
> On 11/10/2023 16.17, Juan Quintela wrote:
>> Fabiano Rosas <farosas@suse.de> wrote:
>>> We're adding support for testing migration using two different QEMU
>>> binaries. We'll provide the second binary in a new environment
>>> variable.
>>>
>>> Allow qtest_qemu_binary() to receive the name of the new variable. If
>>> the new environment variable is not set, that's not an error, we use
>>> QTEST_QEMU_BINARY as a fallback.
>>>
>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> Reviewed-by: Juan Quintela <quintela@redhat.com>
>> Thomas, do you want me to get this through the migration tree?
>
> I'm fine either way, but please give me one or two more days for review first.
Sure.