Re: [PATCH v3 9/10] hw/char/pl011: Add transmit FIFO to PL011State

[Richard Henderson]

On 10/13/23 10:05, Alex Bennée wrote:
> > @@ -487,7 +505,11 @@ static const VMStateDescription vmstate_pl011 = {
> >       .subsections = (const VMStateDescription * []) {
> >           &vmstate_pl011_clock,
> >           NULL
> > -    }
> > +    },
> > +    .subsections = (const VMStateDescription * []) {
> > +        &vmstate_pl011_xmit_fifo,
> > +        NULL
> > +    },
> >   };
>
> Doesn't this necessitate the bumping of the migration version data or
> do we not worry about new -> old migrations?

We usually don't care about new->old, however:

If the fifo is empty, migration will still work because of the subsection.
If the fifo is not empty... I think the subsection will be ignored, with the only 
consequence being that some characters will be dropped.


r~