|
From: | Juan Quintela |
Subject: | Re: [PATCH v2 1/4] migration: check for rate_limit_max for RATE_LIMIT_DISABLED |
Date: | Mon, 16 Oct 2023 09:23:16 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) |
Elena Ufimtseva <elena.ufimtseva@oracle.com> wrote: > In migration rate limiting atomic operations are used > to read the rate limit variables and transferred bytes and > they are expensive. Check first if rate_limit_max is equal > to RATE_LIMIT_DISABLED and return false immediately if so. > > Note that with this patch we will also will stop flushing > by not calling qemu_fflush() from migration_transferred_bytes() > if the migration rate is not exceeded. > This should be fine since migration thread calls in the loop > migration_update_counters from migration_rate_limit() that > calls the migration_transferred_bytes() and flushes there. > > Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com> > Reviewed-by: Fabiano Rosas <farosas@suse.de> > Reviewed-by: Peter Xu <peterx@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> queued.
[Prev in Thread] | Current Thread | [Next in Thread] |